OCPBUGS-74424: migrate yarn 1 to npm by upalatucci · Pull Request #161 · openshift/nmstate-console-plugin

upalatucci · 2026-01-26T17:11:45Z

For konflux we are required to switch

I took the chance to make sure the start-console script support zsh and switched from ts-loader to esbuild-loader for faster loading time

Ref: https://github.com/kubevirt-ui/kubevirt-plugin/pull/2708/changes#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

kubevirt-ui/kubevirt-plugin#3298

openshift-ci-robot · 2026-01-26T17:11:54Z

@upalatucci: This pull request references Jira Issue OCPBUGS-74424, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gouyang

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

For konflux we are required to switch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-01-26T17:13:01Z

@upalatucci: This pull request references Jira Issue OCPBUGS-74424, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gouyang

Details

In response to this:

For konflux we are required to switch

I took the chance to make sure the start-console script support zsh and switched from ts-loader to esbuild-loader for faster loading time

Ref: https://github.com/kubevirt-ui/kubevirt-plugin/pull/2708/changes#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

kubevirt-ui/kubevirt-plugin#3298

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

galkremer1 · 2026-01-26T17:36:11Z

Dockerfile

 # Run install as supper tux
 USER 0
-RUN yarn install --frozen-lockfile --network-timeout 600000 && yarn build
+RUN npm ci && npm run build


Do you think we need to utilize something similar to -network-timeout 600000?

RUN npm config set fetch-retries 5 && \ npm config set fetch-retry-mintimeout 20000 && \ npm config set fetch-retry-maxtimeout 120000 && \ npm ci && \ npm run build

This flag was added because of some issues during cross-platform builds (like S390x build into a AMD platform with buildx) but i'm not sure if we'll get the same issue with npm. We could skip this and then add it if we get same issues with npm. What do u think?

Sounds good.

galkremer1 · 2026-01-26T18:43:58Z

/retest

galkremer1 · 2026-01-27T14:44:19Z

/retest

pcbailey · 2026-01-27T14:59:57Z

/lgtm

galkremer1

/lgtm

upalatucci · 2026-01-28T17:05:27Z

/retest

upalatucci · 2026-01-28T18:24:55Z

/retest

galkremer1

/lgtm

upalatucci · 2026-01-28T20:20:56Z

/retest

openshift-ci-robot · 2026-01-28T22:33:05Z

/retest-required

Remaining retests: 0 against base HEAD d131363 and 2 for PR HEAD c5b26a2 in total

galkremer1 · 2026-01-29T00:34:28Z

/retest

adamviktora · 2026-01-29T08:34:46Z

/retest

upalatucci · 2026-01-29T10:32:05Z

/retest

galkremer1

/lgtm

openshift-ci · 2026-01-29T18:27:39Z

@upalatucci: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

galkremer1

/LGTM

openshift-ci · 2026-01-30T14:10:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: galkremer1, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-01-30T14:15:03Z

@upalatucci: Jira Issue OCPBUGS-74424: All pull requests linked via external trackers have merged:

openshift/nmstate-console-plugin#161

Jira Issue OCPBUGS-74424 has been moved to the MODIFIED state.

Details

In response to this:

For konflux we are required to switch

I took the chance to make sure the start-console script support zsh and switched from ts-loader to esbuild-loader for faster loading time

Ref: https://github.com/kubevirt-ui/kubevirt-plugin/pull/2708/changes#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

kubevirt-ui/kubevirt-plugin#3298

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

OCPBUGS-74424: migrate yarn 1 to npm

81918f7

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 26, 2026

openshift-ci bot requested review from gouyang, pcbailey and vojtechszocs January 26, 2026 17:11

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2026

galkremer1 reviewed Jan 26, 2026

View reviewed changes

switching from ts-laode to esbuild-loader

ea2579b

upalatucci force-pushed the port-to-npm branch from e83c794 to ea2579b Compare January 27, 2026 08:48

audit fix

86dc5cf

openshift-ci bot assigned pcbailey Jan 27, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2026

upalatucci force-pushed the port-to-npm branch from 5b4245d to bc486f5 Compare January 27, 2026 15:29

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2026

upalatucci force-pushed the port-to-npm branch 2 times, most recently from d3af98e to 1c85815 Compare January 27, 2026 15:51

galkremer1 approved these changes Jan 27, 2026

View reviewed changes

openshift-ci bot assigned galkremer1 Jan 27, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2026

upalatucci force-pushed the port-to-npm branch from 1c85815 to fa077ff Compare January 27, 2026 17:00

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2026

fix npm ci issue on prow

8f44169

upalatucci force-pushed the port-to-npm branch from fa077ff to 8f44169 Compare January 28, 2026 08:24

package lock file with npm v8

4a5936f

upalatucci force-pushed the port-to-npm branch 3 times, most recently from 60e5edc to c5b26a2 Compare January 28, 2026 14:51

galkremer1 approved these changes Jan 28, 2026

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2026

upalatucci force-pushed the port-to-npm branch from c5b26a2 to ff99f6c Compare January 29, 2026 15:30

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2026

galkremer1 approved these changes Jan 29, 2026

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2026

npm ci --ignore-scripts

901c2c3

upalatucci force-pushed the port-to-npm branch from ff99f6c to 901c2c3 Compare January 29, 2026 16:58

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2026

galkremer1 approved these changes Jan 30, 2026

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2026

openshift-merge-bot bot merged commit b7f98e3 into openshift:main Jan 30, 2026
3 checks passed

Comments

Conversation

upalatucci commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 26, 2026

Uh oh!

openshift-ci-robot commented Jan 26, 2026

Uh oh!

galkremer1 Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

upalatucci Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

galkremer1 Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

galkremer1 commented Jan 26, 2026

Uh oh!

galkremer1 commented Jan 27, 2026

Uh oh!

pcbailey commented Jan 27, 2026

Uh oh!

galkremer1 left a comment

Choose a reason for hiding this comment

Uh oh!

upalatucci commented Jan 28, 2026

Uh oh!

upalatucci commented Jan 28, 2026

Uh oh!

galkremer1 left a comment

Choose a reason for hiding this comment

Uh oh!

upalatucci commented Jan 28, 2026

Uh oh!

openshift-ci-robot commented Jan 28, 2026

Uh oh!

galkremer1 commented Jan 29, 2026

Uh oh!

adamviktora commented Jan 29, 2026

Uh oh!

upalatucci commented Jan 29, 2026

Uh oh!

galkremer1 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 29, 2026

Uh oh!

galkremer1 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 30, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

upalatucci commented Jan 26, 2026 •

edited

Loading